4 ms·
It really should be saving them to JSON instead of Pickle, but I gave up trying to figure out how to properly rehydrate the openai Completion objects. If it wa
by ianbicking 4y ago
It really should be saving them to JSON instead of Pickle, but I gave up trying to figure out how to properly rehydrate the openai Completion objects.
If it was JSON then it wouldn't be crazy to add it to your repository. (I guess Pickle is stable enough in practice, but it would offend my personal sensibilities to check them in.)
- HyperSane 4y agoWhat is wrong with Pickle?
- andreareina 4y agoArbitrary code execution is a big one.
- HyperSane 4y agoI'm aware, but it is not an issue if you only use it with your own data. You can even cryptographically sign it.
- ianbicking 4y agoBesides security it's pretty opaque, and unnecessarily so. The data all comes over JSON so there's no non-JSONable types involved. It would be nice to be able to run tools like cost summarizing over the JSON without having to load up any other code.