7 ms·
Can code review really catch this? If it is hidden under 20 levels of abstraction and obfuscation?
by deltree7 4y ago
Can code review really catch this? If it is hidden under 20 levels of abstraction and obfuscation?
- adamredwoods 4y agoIn ecommerce we work with money in cents, as an integer. If he was catching pennies off FP rounding errors (as in OfficeSpace), then that is an easy red flag during code review. But the more I think about it, he may have gotten around a code review somehow and pushed to prod (speculation).