4 ms·
EDIT: I originally linked to the wrong review. It's been there since the initial commit of networking: https://github.com/golang/go/commit/e8a02230f215efb075c
by stusmall 4y ago
EDIT: I originally linked to the wrong review. It's been there since the initial commit of networking: https://github.com/golang/go/commit/e8a02230f215efb075cccd4146b3d0d1ada4870e https://github.com/golang/go/commit/e8a02230f215efb075cccd41...
- withinboredom 4y agoLol “back by popular demand” At least it wasn’t for my initial thoughts when seeing PRs around that code “to speed up unit tests”. I’d love to see the discussions though.
- Game_Ender 4y agoThis is actually the review for adding back the ability to turn NODELAY on and off, it was actually in the networking code from the start https://github.com/golang/go/blob/e8a02230/src/lib/net/net.go#L398 https://github.com/golang/go/blob/e8a02230/src/lib/net/net.g...
- stusmall 4y agoThanks! I noticed that right after I posted it. Unfortunately my non-procrastination setting kicked in and I couldn't delete it before anyone saw it.