3 ms·

This should be in a Wasm sandbox. (if performance is so critical--otherwise keep it in userspace). Crazy we keep trading serious CVEs for a little perf.

• deleted 4y ago
  [deleted]
• the8472 4y ago
  Wasm doesn't necessarily help if it's performance-critical because that comes with its own overhead. And the kernel component of ksmbd interacts with other parts of the kernel such as the vfs, sockets/rdma. If you had marshal all the objects into something safe before exposing them to a wasm sandbox (e.g. replacing pointers with some map keys) that'd increase the overhead further.
• pjmlp 4y ago
  The sandbox doesn't protect against corruption inside of linear memory, nor exploits that take advantage of it to try out to influence code execution paths, triggering calls that shouldn't have happened in first place. Great the exploit cannot pown the host, it can nevertheless trigger damaging behaviours.
  • ilyt 4y ago
    To elaborate on point: "Great, the WASM-SMB server didn't crash the kernel, it can ONLY exfiltrate every single file it has access to, which is every important file because it is a file server. But don't worry, your /etc/shadow is safe!" And of course obligatory XKCD: https://xkcd.com/1200/ https://xkcd.com/1200/ I'm happy most HN users don't make anything security-important...