4 ms·
"Don’t let junior SWEs get 2000 lines into a change before submitting a pull request." This is good advice. Share your code early and often so you can get feed
by johnthuss 4y ago
"Don’t let junior SWEs get 2000 lines into a change before submitting a pull request."
This is good advice. Share your code early and often so you can get feedback before you're fully committed to one approach.
- feoren 4y agoYeah, this is insane to me. 2000 lines written well in an expressive programming language is a small but complete library. It's 15 to 30 code files. 2000 lines is just about enough to write a complete spelling and word-use checker with a persistence layer. It's enough to write a generic mass-balance process simulator, or a web security library, or a moderately complex workflow-management library, or a toy game. 2000 lines is a week or two of work. If your junior SWE is writing 2000 lines of code before anyone looks at it, you're basically letting them be raised by wolves.