3 ms·
> And God forbid I needed to extend this interface and missed to add the new method to one of the 32 types implementing it, so that it blows on my face in prod
by cube2222 4y ago
> And God forbid I needed to extend this interface and missed to add the new method to one of the 32 types implementing it, so that it blows on my face in prod at 3AM.
The language has static type-checking. If to you it's a regular thing that something like this blows up in your face, maybe it's the code base doing too many things dynamically, and not the language?
> Great, now I'll have to pull a rickety 3rd-package or ‶just grep bro″ through the whole code base to find what types implement this interface.
Or just use any of the popular Go code editors/plugins which give you a "show me all implementations".
In general, implicit interfaces let structures and functions require much less by defining their needed functionality subset, instead of requiring the whole "domain interface" from somewhere else.
If you have a struct that only needs to list an S3 bucket, it's nice to accept an interface that only requires listing, and not the other 30 methods the AWS library "full" interface has. This makes understanding what a piece of code is doing much easier, while simplifying mocking as well.
I do agree that enums, or even better, sum types, would be desirable. It's not a big issue in my day to day, though.
- pjmlp 4y ago> Or just use any of the popular Go code editors/plugins which give you a "show me all implementations". And me thinking the Go culture is against languages that tend to come with IDEs...
- foldr 4y agoYou don't need an IDE to do that. More or les anything that can hook up with the Go language server will do the job.
- pjmlp 4y agoSo somehow needing a language server to work around language design flaws is alright for Go then.
- foldr 4y agoSarcasm aside, I do think it’s fair to assume that someone writing code in a modern programming language in 2022 has access to basic language-aware editor tooling. That’s the beauty of the language server. You can look up the implementations of an interface from vim, or some other minimalist development environment, if that’s your bag.
- masklinn 4y ago"Go is so simple you don't need an IDE to write it, unlike java" "Well obviously you need a proper IDE to protect you from Go's fuckups" Cool.
- foldr 4y agoYou don’t need an IDE, as I explained in my two preceding posts in this thread. Please at least try to respond to someone who is actually making the arguments that you take yourself to be refuting.
- cube2222 4y agoGo culture, like any other, is diverse. I prefer to use an editor/IDE and don't think it's pleasant to work with any language (including Go) without them.
- za3faran 4y agoNot to mention how slow it becomes in large projects
- shakow 4y ago> The language has static type-checking. No it does not, at least not completely. When you carry around pointers to struct implementing interfaces, it does not check for anything at compile time. > Or just use any of the popular Go code editors/plugins which give you a "show me all implementations". Does not work all the time, hence my use of the ‶rickety″ adjective. > This makes understanding what a piece of code is doing much easier, while simplifying mocking as well. That's a design problem, not an interface problem. Split you giant 30-methods interface into smaller ones if need be, that the whole point of interfaces: not be a 1-1 mapping to methods, but a semantic (sub)group of them.
- foldr 4y ago>When you carry around pointers to struct implementing interfaces, it does not check for anything at compile time. What exactly do you mean here? You can't assign a value that doesn't implement an interface Foo to a variable of type Foo. That will cause a compile time error.
- cube2222 4y ago> That's a design problem, not an interface problem. Split you giant 30-methods interface into smaller ones if need be, that the whole point of interfaces: not be a 1-1 mapping to methods, but a semantic (sub)group of them. It really isn't. This way it becomes a guessing game "Which methods will be used with which other ones?". Even if I have a KVStore interface with 4 methods: Get, Set, List and Delete, it's a huge value to future code readers if my new structure only accepts an interface with List and Get, or List and Delete. The other commenter already responded to your static typing assertion, so leaving that for there (it absolutely does check it).
- za3faran 4y ago> it's a huge value to future code readers if my new structure only accepts an interface with List and Get, or List and Delete. But that's not specific to golang. You can use the same approach in Java, Kotlin, C#, etc
- 4y ago