9 ms·
> certainly wasn't following 2022 best practices by any means Could you please share a few examples of best practices not followed?
by Tomis02 4y ago
> certainly wasn't following 2022 best practices by any means
Could you please share a few examples of best practices not followed?
- deleted 4y ago[deleted]
- jerf 4y agoThere was no unit testing, no valgrind or anything like that, no documentation... I mean, honestly, other than the fact it compiled, worked, and was broadly speaking safe to use by virtue of not being on the network (it's a batch conversion process with the input being fairly rigidly constrained, no external user input basically), it didn't have much of anything else going for it. I think what comments it had in it may even have been wrong; I didn't stare at it enough to be sure. My intuition says it should have been running about 10 times faster than it was, too. Not sure if I'm just too used to multithreaded performance nowadays, if there was actually something wrong in there, or if I was wrong for some reason.