3 ms·

Hmm. So what happens when two versions are released in one day?

• layer8 4y ago
  They can hop timezones. There’s (almost) always two dates that are “today” depending on timezone.
• macintux 4y ago
  This is only for breaking changes, apparently, so presumably that situation won’t arise.
  • timrogers 4y ago
    Author here. That's exactly our thinking - we are making the assumption that we won't want to release two versions with breaking changes on the same day. Who knows, maybe we will be proved wrong, but we think it's a safe bet.
    • macintux 4y ago
      Thanks. I would be remiss if I didn’t take this opportunity to ask: the current API for retrieving commit metadata relies on git’s information about the committer, but you have much better information available to you. You know who actually pushed the commit. In an enterprise setting, that’s a big deal, because it’s easy for users to have misconfigurations. We have no shortage of commits in our repositories from ec2-user or root. I don’t think it makes sense to replace the information git supplies, but could you please augment it?
      • timrogers 4y ago
        Could you drop me an email at timrogers at github dot com? I'd love to look into this.
        • macintux 4y ago
          Sure, will dig a bit to make sure I remember the details and send you something, probably next week after I return from vacation. Thanks!