4 ms·
the reviewer should make 'nit' changes directly rather than pass a mini-ticket for evaluation back to the author. why are reviewers so scared to modify prs at o
by wahnfrieden 4y ago
the reviewer should make 'nit' changes directly rather than pass a mini-ticket for evaluation back to the author. why are reviewers so scared to modify prs at orgs?
- atq2119 4y agoThat's an interesting thought. Personally, I feel messing with another person's personal branch is dangerous. They might already have some change locally, which is going to lead to surprises, and most of the people I work with unfortunately don't know Git well enough. It's something that could be addressed on an organizational level perhaps. The other point to consider is the whole teach a man to fish vs give them a fish thing. Teaching is better in the long run.
- wahnfrieden 4y agoTeaching: you can still comment and edit. And your edit in the PR is reviewable by the author. Org level: absolutely. Solvable thru tooling.