3 ms·

Meta had the best code review quality I've seen in my career.

by bagels 4y ago

nomel 4y ago
As someone who has only experienced terrible code reviews, could you give a little summary of what you liked?
- antiterra 4y ago
  They probably had some pretty good cat meme image macros.
  - bagels 4y ago
    Yes good meme macros too. I left a few in my wake.
- bagels 4y ago
  Calling you out for lazy work. Teaching you how to use internal tools, company coding standards, suggesting better patterns, digging deep in to the context of system design and maintainability, suggesting other domain experts to tag in the reviews. I learned all sorts of Hack things that obviously I wouldn't learn outside from code reviews.
  - jackblemming 4y ago
    - dieselgate 4y ago
      Boo, please consider a review of the HN comment guidelines https://news.ycombinator.com/newsguidelines.html https://news.ycombinator.com/newsguidelines.html Could you potentially explain what makes it "some of the most garbage software imaginable"? edit: wording
      - jackblemming 4y ago
        There's already many articles posted to hackernews frequently at the insane internals of the mobile app, to the "meta verse", to many other things. Most of which are posted by ex-Facebook engineers. I don't need to rehash the same conversations, nor do I need to grant Facebook of all corporations any sort of courtesy.
        gtirloni 4y ago
        The courtesy is towards us, people engaging in this discussion. Meta is not a party here.
    - RussianCow 4y ago
      Name one successful company that only produces beautiful, elegant, and readable code, with no nasty warts or hacks. I'll wait.
      - KronisLV 4y ago
        > Name one successful company that only produces beautiful, elegant, and readable code, with no nasty warts or hacks. Honestly, I'd genuinely like to hear some of the answers to this, or even just mentions of good codebases to explore. That said, I don't think that there will be that many that satisfy all of the requirements listed here, because as the scope of a project grows, there will almost inevitably be some technical debt or accidental complexity, or even subjective things.
    - bagels 4y ago
      I mean, I generally think comments with this kind of attitude aren't looking for serious responses, so I normally don't respond. That said, there are three things to consider: 1) I honestly don't care whether you think it's garbage or not. 2) I saw some amazing software there, and I saw some that wasn't amazing. 3) It's an immense business, and there is a certain amount of inherent dysfunction that comes with that many people working on anything together much as you would see at any large company.
  - dieselgate 4y ago
    How are small things like "you left a commented out print/log" or "use color var not hex code" handled - or that a 'company coding standards' type thing. Are those types of things potentially automated with a linter or similar?

Meta had the best code review quality I've seen in my career.

by bagels 4y ago

Meta had the best code review quality I've seen in my career.

nomel 4y ago

As someone who has only experienced terrible code reviews, could you give a little summary of what you liked?

antiterra 4y ago
They probably had some pretty good cat meme image macros.
- bagels 4y ago
  Yes good meme macros too. I left a few in my wake.
bagels 4y ago
Calling you out for lazy work. Teaching you how to use internal tools, company coding standards, suggesting better patterns, digging deep in to the context of system design and maintainability, suggesting other domain experts to tag in the reviews. I learned all sorts of Hack things that obviously I wouldn't learn outside from code reviews.
- jackblemming 4y ago
  - dieselgate 4y ago
    Boo, please consider a review of the HN comment guidelines https://news.ycombinator.com/newsguidelines.html https://news.ycombinator.com/newsguidelines.html Could you potentially explain what makes it "some of the most garbage software imaginable"? edit: wording
    - jackblemming 4y ago
      There's already many articles posted to hackernews frequently at the insane internals of the mobile app, to the "meta verse", to many other things. Most of which are posted by ex-Facebook engineers. I don't need to rehash the same conversations, nor do I need to grant Facebook of all corporations any sort of courtesy.
      - gtirloni 4y ago
        The courtesy is towards us, people engaging in this discussion. Meta is not a party here.
  - RussianCow 4y ago
    Name one successful company that only produces beautiful, elegant, and readable code, with no nasty warts or hacks. I'll wait.
    - KronisLV 4y ago
      > Name one successful company that only produces beautiful, elegant, and readable code, with no nasty warts or hacks. Honestly, I'd genuinely like to hear some of the answers to this, or even just mentions of good codebases to explore. That said, I don't think that there will be that many that satisfy all of the requirements listed here, because as the scope of a project grows, there will almost inevitably be some technical debt or accidental complexity, or even subjective things.
  - bagels 4y ago
    I mean, I generally think comments with this kind of attitude aren't looking for serious responses, so I normally don't respond. That said, there are three things to consider: 1) I honestly don't care whether you think it's garbage or not. 2) I saw some amazing software there, and I saw some that wasn't amazing. 3) It's an immense business, and there is a certain amount of inherent dysfunction that comes with that many people working on anything together much as you would see at any large company.
- dieselgate 4y ago
  How are small things like "you left a commented out print/log" or "use color var not hex code" handled - or that a 'company coding standards' type thing. Are those types of things potentially automated with a linter or similar?