4 ms·

I find Google's take on code reviews to be particularly good: https://cloud.google.com/architecture/devops/devops-tech-trunk-based-development#common_pitfalls

• ok_dad 4y ago
  I enjoy how they state like 3 times that code reviews should be synchronous, yet "industry-standard" (aka: what people really do) is to toss it over the fence in a PR and go back and forth for several days with stylistic bullshit.
  • Jensson 4y ago
    Code reviews are usually synchronous at Google though, commenting and fixing things is like chatting with the reviewer so are usually done quickly. Not sure why this wouldn't be industry standard, is there any reason to make code reviews more painful than that?
    • ok_dad 4y ago
      I was kinda joking that places like Google might have good processes but most places just cargo cult it and do it incorrectly. My current job does reviews that are so useless I don’t even participate anymore and no one cares. I really want to work at a place where they care about code quality and an effective process.