3 ms·
The interactive tool looks amazing. I do interactive rebases quite often and a drag-drop setup is wonderful However, I don't understand why I would want 1 PR p
by conradludgate 4y ago
The interactive tool looks amazing. I do interactive rebases quite often and a drag-drop setup is wonderful
However, I don't understand why I would want 1 PR per commit. I feel like that's a non-starter for me.
Is the idea that no one should use branches - so there's only 3 points of interest: HEAD, main, and origin/main? And then is the idea that it's only 1 commit per feature to merge?
So I would work on something, make a PR, continue working on something else without making any git checkouts and then make a new PR?
- arxanas 4y agoGenerally, you "stack" your commits/PRs and review them in small units (which I think is what you mean by working on something else without making any Git checkouts). But you can certainly create new "branches" of development which aren't stacked on top of each other. They just don't have to have names. You can consider them to be "anonymous" branches. The main advantage of 1 commit per PR is to review and commit smaller changes (a single commit at a time).
- juped 4y agoNo, stacking is a (partial) workaround for Github "pull requests" being bad, by reimplementing the ordinary Git way to submit changes (one email per commit, reviewable inline. look at any patch thread at https://public-inbox.org/git/ https://public-inbox.org/git/). Doing this doesn't really make them good, but it makes them at least reviewable.