3 ms·
The first thing I look at when reviewing a pull request is the total lines of code added and removed. If the number is over a certain amount (it differs dependi
by jspash 4y ago
The first thing I look at when reviewing a pull request is the total lines of code added and removed. If the number is over a certain amount (it differs depending on the language and task) I will immediately reject it and ask for a one-on-one. Too many additions or deletions are a signal that something went wrong somewhere. Either the dev went off piste or the task wasn't properly specified. Or sometimes an auto-formatter has gone on the fritz and "prettiered" everything up.