4 ms·

I believe the Samsung Galaxy Book Go was tested with OpenBSD during the initial development for the ThinkPad x13s, keyboard support was added in this commit. h

I believe the Samsung Galaxy Book Go was tested with OpenBSD during the initial development for the ThinkPad x13s, keyboard support was added in this commit. https://github.com/openbsd/src/commit/74edc71ccae4051eda11fa3fb27de52f69e7512e https://github.com/openbsd/src/commit/74edc71ccae4051eda11fa... Many of these older generation "Windows on Snapdragon" laptops unfortunately did not use fast NVMe storage however, only slow eMMC and eUFS (Universal Flash Storage), the latter currently being unsupported by OpenBSD.

mdaniel 4y ago
As best I can tell, there are exactly two comments in that file (I don't count the licensing and ahem CVS metadata), and neither of them add any enlightenment at all. Kernel development must be a very special culture. I tried finding the equivalent file in the Linux kernel, but while looking I saw there is at least one example of commentary to go along with a struct: https://sourcegraph.com/github.com/torvalds/linux/-/blob/drivers/pinctrl/qcom/pinctrl-msm.c?L39 https://sourcegraph.com/github.com/torvalds/linux/-/blob/dri...
- notaplumber1 4y ago
  Apologies, I was pointing out the commit message itself rather than the contents of the commit, it's indeed full of magic numbers. It's reverse engineered, there are no docs from Qualcomm. This is commit is plumbing work fixing GPIO support, which indirectly makes the keyboard work. I don't have any boot logs for the machine, but as I understand they have standard Microsoft-compatible HID keyboards/touchpads that work with OpenBSD's existing drivers. https://man.openbsd.org/qcgpio https://man.openbsd.org/qcgpio https://man.openbsd.org/qciic https://man.openbsd.org/qciic
  - mdaniel 4y ago
    Yes, sorry, I wasn't directing the vile at you, that was just the first time I had seen a file from the OpenBSD kernel and was shocked at how aggressively opaque it was And, to your point, if it was reverse engineered, that's more reason to comment, not less, because (a) memory is fleeting (b) if I wanted to contribute, I could read along about how Zen Master OpenBSD Reverser found those so I could go find more

mdaniel 4y ago

As best I can tell, there are exactly two comments in that file (I don't count the licensing and ahem CVS metadata), and neither of them add any enlightenment at all. Kernel development must be a very special culture. I tried finding the equivalent file in the Linux kernel, but while looking I saw there is at least one example of commentary to go along with a struct: https://sourcegraph.com/github.com/torvalds/linux/-/blob/drivers/pinctrl/qcom/pinctrl-msm.c?L39 https://sourcegraph.com/github.com/torvalds/linux/-/blob/dri...

notaplumber1 4y ago
Apologies, I was pointing out the commit message itself rather than the contents of the commit, it's indeed full of magic numbers. It's reverse engineered, there are no docs from Qualcomm. This is commit is plumbing work fixing GPIO support, which indirectly makes the keyboard work. I don't have any boot logs for the machine, but as I understand they have standard Microsoft-compatible HID keyboards/touchpads that work with OpenBSD's existing drivers. https://man.openbsd.org/qcgpio https://man.openbsd.org/qcgpio https://man.openbsd.org/qciic https://man.openbsd.org/qciic
- mdaniel 4y ago
  Yes, sorry, I wasn't directing the vile at you, that was just the first time I had seen a file from the OpenBSD kernel and was shocked at how aggressively opaque it was And, to your point, if it was reverse engineered, that's more reason to comment, not less, because (a) memory is fleeting (b) if I wanted to contribute, I could read along about how Zen Master OpenBSD Reverser found those so I could go find more