10 ms·
If GP wrote a significant part of the code that is being modified it seems like it would be a good idea to involve them in the review. It is a chance to share t
by kevincox 4y ago
If GP wrote a significant part of the code that is being modified it seems like it would be a good idea to involve them in the review. It is a chance to share their expertise and catch bugs early. I don't think it shuold be required or blocking but automatically CCing a few people who have recently changed the code seems like a smart idea.
I don't think "managing the web of contributions" seems too impractical. If for example you CC the top 3 contributors who authored the lines that were changed or modified (excluding large automate or "tree-wide" changes) then for any line you write you are getting notified at most once. In practice it will be much less than that since multiple lines will be changed at a time and you won't always be in the top 2 or 3. Plus consider that many of these people are qualified to review the code and would need to be in that discussion anyways. What I'm trying to say is that the data is there and available automatically and the cost of reviewing follow-ups is bounded.