5 ms·
Sounds like the tests around what you were trying to achieve with your changes weren’t complete enough, possibly?
by dcormier 4y ago
Sounds like the tests around what you were trying to achieve with your changes weren’t complete enough, possibly?
- silisili 4y agoIIRC, it was an overhaul and improvement some months later. I didn't mean to at all imply that our code was better or that we knew better - the overhaul was much needed, only that the review process seemed broken. This was 8-9 years ago, so not exactly fresh in my brain.
- deleted 4y ago[deleted]
- deleted 4y ago[deleted]
- sangnoir 4y ago> I didn't mean to at all imply that our code was better or that we knew better >> [...]when a Googler started messing around in that portion of the code, changed it,[...] it ended up having bad behavior Your word choice did no favors to your intention.