4 ms·
Most likely your problem is with the Gerrit "Reviewers by Blame" plugin, which contextually uses the last editor of the code to determine who to ping to review
by zdw 4y ago
Most likely your problem is with the Gerrit "Reviewers by Blame" plugin, which contextually uses the last editor of the code to determine who to ping to review the code. Makes total sense if the developers are still there, but that's obviously your problem - they're not there. https://gerrit.googlesource.com/plugins/reviewers-by-blame https://gerrit.googlesource.com/plugins/reviewers-by-blame
The plugin also will determine if the user is "Active" - maybe what needs to happen is that the Go Devs need to make a sweep and mark everyone on their Gerrit who hasn't committed in say 6 months as not Active: https://gerrit.googlesource.com/plugins/reviewers-by-blame/+/refs/heads/master/src/main/java/com/googlesource/gerrit/plugins/reviewersbyblame/ReviewersByBlame.java#201 https://gerrit.googlesource.com/plugins/reviewers-by-blame/+...
That said even after the cleanup of active users this is fundamentally a human problem with a part of the codebase that isn't being actively maintained.
As an aside - I really like Gerrit. It's leaps and bounds better than GitHub if your goal is putting code review front and center as the important task to accomplish, as opposed to search and making a fancy webpage. But YMMV.
- remus 4y ago> Most likely your problem is with the Gerrit "Reviewers by Blame" plugin... I suspect it will also be related to a recent change where every CL needs to be signed off by two google employees. Reducing the number of people who can +1 CLs is going to make it harder to get +1s on your CLs. Reading between the lines I suspect some on the go team at google find it a frustrating situation where they have to rubber stamp contributions from trusted and capable contributors. https://groups.google.com/g/golang-dev/c/K7oGURi0wTM https://groups.google.com/g/golang-dev/c/K7oGURi0wTM
- Kon-Peki 4y agoIf someone is qualified to review code when they are employed by Google, then that qualification doesn't go away when they leave Google. Unless, perhaps, this requirement is arbitrary...
- chrsig 4y agoI interpreted the requirement that they needed to be google employees as a legal requirement of some sort rather than anything related to qualifications.
- hanwenn 4y agoI am the manager for the Gerrit team at Google. I can assure you that the 'reviewers-by-blame' plugin is not currently used on any Google Gerrit instance.
- zdw 4y agoFirst, thanks for working on Gerrit - it's an excellent product that I really love working with! Second, is it public how the contextual assignment of reviewers works on the Go project?