3 ms·
I am a little confused by his expectations. He describes it as a "what should've been a 30 minute fix patch" and "a 1700-line patchset that implements 3 kernel
by thethirdone 4y ago
I am a little confused by his expectations. He describes it as a "what should've been a 30 minute fix patch" and "a 1700-line patchset that implements 3 kernel modules".
If he is expecting his code to be reviewed at the speed of 1 line / second, that just seems really fast for kernel C. Alternatively, if he is expecting the maintainers to not understand the details of the modules, that is something I would be uncomfortable with as a maintainer. I would want to make sure that new code meets my standards and that I understand why any complexity in the code exists.
If he is expecting his involvement in the review to only take 30 minutes that's more reasonable, but for mainlining stuff from Asahi, it seems like having upstream understand what is special about M1 is probably worth your time to explain / convince.