4 ms·
> Like dude, if you aren't going to step into my world and actually understand what I'm trying to do here, just suck it up and ack my patch. > It is not my job
by schainks 4y ago
> Like dude, if you aren't going to step into my world and actually understand what I'm trying to do here, just suck it up and ack my patch.
> It is not my job to drag you kicking and screaming until you either give up or have a lightbulb moment.
Soooo, you're saying if I submit a 1700 line change to _your_ codebase, step into your world and "actually understand" what you're trying to do, you'll just magically _approve_ my commits, no questions asked? Sounds pretty irresponsible.
Yes, you do have to drag people kicking and screaming into your better world. They think their world is pretty neat already! Proving yours is better actually takes patience and work.
- dottedmag 4y ago
- googlryas 4y agoI can only guess the author isn't thinking systematically about this issue. They know their own motivations, their own coding skills, their own reasons for doing everything, and they know they are submitting well intentioned, beautiful, useful code. But how do the maintainers know that? They have to review and accept patches from hundreds or thousands of people. Maybe everything would be perfectly fine if they just blindly ack'd the patch from this particular author. But that is certainly not what they should just generally do.