3 ms·
In my experience, this only works if you have a small team of great engineers. Once you have 50+ people of various skill levels making contributions to the code
by int0x2e 4y ago
In my experience, this only works if you have a small team of great engineers. Once you have 50+ people of various skill levels making contributions to the codebase, you'll start seeing your git history littered with variants of "fix", "fix 2", "fix broken CI test" and on and on...
For me, the PR is the context I can use when trying to find an issue.
Sifting through many hundreds of commits per day is painful. Sifting through tens of PRs per day is not great, but is much more manageable...
- seba_dos1 4y ago> you'll start seeing your git history littered with variants of "fix", "fix 2", "fix broken CI test" and on and on... Should such commits even pass through the review in the first place?
- m000 4y agoIf the team hasn't agreed to not allow this kind of messages, they will get through. And if you're the only one asking for better messages, your colleagues will start seeing you as pushy, and the requested changes as personal favors. The problem is that if good commit practices aren't established very early in the project, they're unlikely to be adopted later when the team grows (assuming that the whole team has a say on the decision).