4 ms·

I don't feel I'm moving the goal posts. I'm relating what I did with numbers. Others may have assumed my goals. My goal was to reduce the risks that the acquir

I don't feel I'm moving the goal posts. I'm relating what I did with numbers. Others may have assumed my goals. My goal was to reduce the risks that the acquiring company felt were the biggest. I did that in 8 hours. Then we focused on specific risks previously identified in the review. That usually took the form of asking the selling company to explain, not for me to read more code. Usually the answers clarify the concerns, or admit them.

chris_wot 4y ago
That's not really code review though, I'd argue. The report was that they wanted their code printed on paper, and to review it. That seems very... specific to the code itself. Not the same as reviewing code coverage, documentation and Ops specific workflows. Of course, those things are absolutely vital, and must be long and tedious work, and I give you kudos for having these skills :-)