5 ms·
That's probably fine, honestly. I'd maybe take a little more context in the message, but I certainly write messages like that myself. It's always later when I'm
by donatj 4y ago
That's probably fine, honestly. I'd maybe take a little more context in the message, but I certainly write messages like that myself. It's always later when I'm looking into problems that I want more context. I spend a lot of time hunting down problems. Half the time I caused them.
I know tone/angle of commit messages is an entirely separate bag of cats that people have strong opinions about, but I find the tone strange. I generally fond of commits that state what the commit does. Something along the lines of "Adds optional table support"
- js2 4y ago> Adds optional table support Ahem, "Add optional table support" Because: imperative mood. :-) I was an early git contributor and I've modeled my commits from the git project ever since.
- simonw 4y agoI can never remember which tense is recommended for git commits - I keep meaning to figure that out and try to make a habit of if.
- mklein994 4y agoIt's called the Imperative Mood[0]. I like to think of it as though I'm completing this statement: "If you apply this patch, this commit will [Do The Thing™]". Here's a few examples: If I were to apply this patch, this commit will… - Simplify FooWidget - Add optional table support - Remove trailing whitespace - Update fizzbuzz to 1.2.0 - Merge branch 'feature/ABC-123-foobar' - Revert "Add foo to bar" [0]: https://en.wikipedia.org/wiki/Imperative_mood https://en.wikipedia.org/wiki/Imperative_mood
- simonw 4y agoThanks, that's a really clear explanation. I'm going to try that out and see if it sticks for me.