3 ms·
> Merged a pull request without a review - 100% toxic. There's a case where this is not just ok, but healthy (especially on smaller teams) - if you're comforta
by jamie_ca 4y ago
> Merged a pull request without a review - 100% toxic.
There's a case where this is not just ok, but healthy (especially on smaller teams) - if you're comfortable doing trunk-based development then you can use a PR to "snapshot" a set of changes and either invite commentary or just have a link to share as an FYI around the change, without the awkwardness of linking to an unnamed commit sequence.
https://martinfowler.com/articles/ship-show-ask.html https://martinfowler.com/articles/ship-show-ask.html
- nuc1e0n 4y agoI would say this is never healthy, even for a team of 2 people. These days merging code without at least asking for a review should be anathema for devs. Even a 'rubber stamping' review at least signifies a shared awareness of changes.
- NoahTheDuke 4y agoOther workflows exist; pretty silly to act like you’ve found the One True Way.
- nuc1e0n 4y agoIf you don't care about code reviews, why care about a PR process? don't protect the branch and just make your commits. The notion of a pull request is you're requesting someone pull in your changes. But you don't want them to review those changes?!
- pferde 4y agoYes, you can get that badge safely only if you adjust your project's development flow. This exactly proves the central point of the article - gamification affects software developers.
- belmont_sup 4y agoViewed from a different lens, these achievements seem intended for new GitHub users. I recall merging my OWN pr into my own new repo. I was surprised with a badge. No harm in that.