4 ms·
I find a lot of typos in documentation and I never create a PR lest people think I am one of those people. They really do make things worse for everyone.
by ficklepickle 4y ago
I find a lot of typos in documentation and I never create a PR lest people think I am one of those people. They really do make things worse for everyone.
- userbinator 4y agoI think that's the sort of thing which should be tacked onto other, more substantial changes. "By the way, I also fixed a few typos in the documentation" is much better than making that your ONLY change.
- maximilianroos 4y agoAgain — disagree — the cost of reviewing diffs is superlinear in their size, with a tiny intercept of the manual steps of opening the PR and clicking "Merge". Maybe this is too extreme but I cannot remember seeing a PR too small, and I've merged thousands.
- maximilianroos 4y agoHonestly this is baffling to me — who doesn't appreciate PRs fixing typos? Does even the parent commenter agree with this, assuming they're actual typos? I both try and make these PRs, and appreciate others doing it! That's how things get better.
- JelteF 4y agoHonestly these are my favorite PRs to receive for my open source side projects. They are easy to review and approve. The smaller the PR the less time consuming it is for me to deal with them. Big PRs that add complex new features are also appreciated of course. But setting apart time to review them is often hard given other responsibilities that I have. And often I personally don't even need the feature that's being added.
- PedroBatista 4y agoThis is insane. What makes things worse for everyone is little documentation cobbled together in 5min like the homework of a teen just before class. Your genius code is useless in isolation.