3 ms·
For example: In Go you have `x.Close()` / `err := x.Close()` that returns an error and if someone starts to check/assert those usages in tests which you have ig
by toimtoimtoim 4y ago
For example: In Go you have `x.Close()` / `err := x.Close()` that returns an error and if someone starts to check/assert those usages in tests which you have ignored in test code. I think they are pushing the limits. No - these do not add value. No new use-cases are being checked, no improvement to coverage etc.
or typo check tests.
I do not reject these PRs. I review these and merge but I feel annoyed.
This non-sense started somewhere around start of 2022. Before that I rarely ever see PRs like that.
- robswc 4y agoCould it be people using CoPilot trying to score brownie points? lol
- maximilianroos 4y agoThem doing it and you getting annoyed sounds like a bad equilibrium! I'd echo the sibling comment re adding what is / isn't appreciated into a CONTRIBUTING.md. My guess is people are doing it to get their feet wet with the repo, being helpful on the margin, and would not do it if they thought it was unhelpful on the margin. Here's PRQL's: https://github.com/prql/prql/blob/main/CONTRIBUTING.md https://github.com/prql/prql/blob/main/CONTRIBUTING.md