4 ms·
I think another factor here is if the reviewer is working on the same code base and the project has a complex environment to set up (e.g., a library compiled wi
by noam_k 4y ago
I think another factor here is if the reviewer is working on the same code base and the project has a complex environment to set up (e.g., a library compiled with custom flags), then `git stash` may not be enough to checkout the branch and run tests. (I am unfortunately guilty of creating some projects like that myself...) Docker can help with these cases, but not all projects are docker-oriented.
I personally like running the code myself when reviewing, it's just not always practical.
- datavirtue 4y agoYeah, reality: no one is going to download code and try to run it. It would take them all day to do code reviews. You are supposed to go live with your buggy shit soon, that's what the business values. Once it's live it gets tossed over the wall and the maintenance process begins where lower paid workers tinker with it until they have the skills to code-and-bail also.