3 ms·
I also blame the tooling a bit. After using Critique [1] internally at Google all the other tools/implementations/UIs feel very confusing. And I'm not speaking
by marcyb5st 4y ago
I also blame the tooling a bit. After using Critique [1] internally at Google all the other tools/implementations/UIs feel very confusing. And I'm not speaking with lack of integration with other tools like coverage, linters, spell checks, error-prone constructs analysis, ... but simply the UI.
Additionally within Google (or at least the teams I was in) really tries to chunk changes in small pieces. For instance, adding a feature always entails something like: 1 CL to introduce the flag that will enable/ disable the feature, at least 1 CL that actually adds the logic and tests, 1 that enables the flag in the deployment. Not sure if that's due to the monorepo or more of a culture thing, but that MO is not that common in my personal experience
[1] https://abseil.io/resources/swe-book/html/ch19.html https://abseil.io/resources/swe-book/html/ch19.html
- codeapprove 4y agoI agree that the tooling is very underrated! It’s strange that programmers spend so much effort choosing their code writing environment (IDE, etc) but just take what they’re given when it comes to code reviewing (mostly GitHub PRs) If you’re missing Critique, allow me to shamelessly plug CodeApprove: https://codeapprove.com https://codeapprove.com Just like Critique, it’s a code review tool for power users that really lets you focus on resolving every discussion.
- marcyb5st 4y agoThanks! Will definitely have a look!
- rob74 4y agoWell, you can decide more or less by yourself what tools you use for writing code, but the code review tool is something everyone needs to agree upon (and then convince management to change), so of course it has more inertia. I'd love to use something else than Jira for issue tracking too, but if the whole company uses it...
- omarelbie 4y agoWhat would you go with instead of Jira? At a small startup here so there's still hope