3 ms·
On the Importance of Pull Request Discipline
- mattpallissard 4y agoI'm mostly on board with this. Although to be frank, I don't give a damn about PR's. I only care about commits. Because commits exist in the codebase, PR's exist in a platform (GitHub, gitlab, email). I've moved many code bases to different platforms and that history is more or less abandoned, especially if it's a hosted solution. Side note; > Linter fixes and updates after code reviews shouldn’t be their own commit. Agreed. Unless your codebase wasn't previously linted/formatted. Then it's better to have them in a separate commit. Ideally before the change. Reviewing diffs that mix white space/formatting changes with logic makes me want to poke pencils in my eyes.