2 ms·

I tried to reverse engineer the python code of gimme-aws-creds and it was parsing/scraping an HTML response from AWS. If that's what it has to do, well ok, but

I tried to reverse engineer the python code of gimme-aws-creds and it was parsing/scraping an HTML response from AWS. If that's what it has to do, well ok, but the fact it wasn't a json service was a bit WTF

mdaniel 4y ago
Ah, it's SAML-specific (https://sourcegraph.com/github.com/Nike-Inc/gimme-aws-creds/-/blob/gimme_aws_creds/aws.py?L85 https://sourcegraph.com/github.com/Nike-Inc/gimme-aws-creds/...) although the majority of BS4 seems to be about driving Okta not AWS: https://sourcegraph.com/github.com/Nike-Inc/gimme-aws-creds/-/blob/gimme_aws_creds/okta.py?L149 https://sourcegraph.com/github.com/Nike-Inc/gimme-aws-creds/... Yeah, SAML is, as far as I know, always headed. My copy of aws-vault is bright enough to launch against our AWS SSO provider(1), which secretly is also SAML to Okta, but I guess if your company's setup doesn't use AWS SSO then Nike must have thought parsing HTML to be The Solution™ 1: https://sourcegraph.com/github.com/99designs/aws-vault/-/blob/cli/login.go?L103 https://sourcegraph.com/github.com/99designs/aws-vault/-/blo...