3 ms·
The junior devs make mistakes. The PR should be a platform for learning from the senior. Therefore I don't understand what lesson is the junior supposed take fr
by Jerry_Fr6VryI 4y ago
The junior devs make mistakes. The PR should be a platform for learning from the senior. Therefore I don't understand what lesson is the junior supposed take from this action:
> I let it go and know that I'll refactor it when I next touch that code
You accept it and then you rewrite it. Simple but as a dev, I would feel let down by the fact that my work was just temporary. This would make me bitter not more experienced. Also, I didn't learn what was the problem so the same situation make repeat.
If you discussed your opinions talk with the PR authors, then it's them who should rewrite the code, not somebody else.
Do you agree with this?