4 ms·
It's really funny from the perspective of the code review: Reviewer: This block of code is a bit confusing. Could you replace with a simpler and shorter versio
by PreachSoup 4y ago
It's really funny from the perspective of the code review:
Reviewer: This block of code is a bit confusing. Could you replace with a simpler and shorter version like this? (Suggest edit)
Reveiewee: I agree with you. But nah I will keep it. Oops shipped!
- birdyrooster 4y agoLearning to say no was the single best thing I could do to improve my shared coding experience.
- rustyminnow 4y agoThe proposed changes were "cuts". The reviewer said "remove these lines, we don't need them" not "can you clarify". So more like: Reviewer: I don't like this code - so we don't need it. Take it out. Reveiewee: Umm what? I can clean it up, but it's kind of essential