4 ms·
I agree with a lot of your points, but it's important to note that being direct is not a free pass for being an asshole. For example: if Bob sucks at SQL, and
by vonseel 4y ago
I agree with a lot of your points, but it's important to note that being direct is not a free pass for being an asshole.
For example: if Bob sucks at SQL, and that happens to be one of your strengths, don't say stuff like "Man, these SQL scripts are trash" or "Dude, your SQL is ass, let me write it" - instead, something like "Hey, I noticed our db code is looking pretty rough, do you want some help cleaning things up?".
- afarrell 4y agoOr be kind yet direct by admitting your own need. “Hey Bob, I need to trust that when I open a PR of yours to review, that the SQL is not going to need a high decree of scrutiny. I’ve seen some bad habits that I’m willing to explain specifically, but first I need to hear that you’re willing to spend time to improve up your SQL skills or mindset.”
- saimiam 4y agoToo much “I” in this style. “Bob, your SQL PRs tend to take longer than usual and I’ve noticed it is because of a few technical things in how the sql is written. I used to make similar mistakes. Can we review these patterns of issues tomorrow?”
- afarrell 4y agoTrue. I’m being oversensitive to the risk of someone else taking things personally.