3 ms·
I am really confused by this post. It definitely sounds that the senior developer might be a bit older thand the poster and might have a different opinion on ho
by _ph_ 4y ago
I am really confused by this post. It definitely sounds that the senior developer might be a bit older thand the poster and might have a different opinion on how to do certain things. There is definitely the need for some conversations.
The critique is a mixed bag in my eyes, there are some things in there I wouldn't consider a bad thing. Like file size. Yes, you shouldn't literally put everything into a single file, but there are some pros and cons about it. Editors are usually really good about handling large files, but often not so good on working on lots of small files. Code which belongs together, should be together. I certainly think that the habit of having lots of files with just a few lines of code in each is a bad one. As with many things, the trick is to find the best balance.
Same with variable names. The closer the scope, the more they are used, the shorter they should be. Again, of course, with taste. Calling a loop variable i is actually a good practise, especially if it is an index. With nested loops that becomes a bit more careful to do. Of course anything with a large scope or infrequent uses across the code, should have a long and descriptive name.