3 ms·
Refactor then functional changes is the right play where reviewers are involved. It separates moving things around and renaming, which is really noisy in a diff
by JonChesterfield 4y ago
Refactor then functional changes is the right play where reviewers are involved. It separates moving things around and renaming, which is really noisy in a diff tool, from the functional change which hopefully changes much less code.
The first review is looking for any functional change in the noise, the second to assess a functional change without any noise. Adding tests in the first phase is great but existing ones shouldn't change. Maximises chance of review finding mistakes / minimises cost to review.