3 ms·
Would be much better if these changes were a branch on the starting repo rather than entire refactors with many changes.
by whywhywhywhy 4y ago
Would be much better if these changes were a branch on the starting repo rather than entire refactors with many changes.
- minimaxir 4y agoThere are pros and cons to each of these Stable Diffusion hacks (usually time/memory/usability tradeoffs) so it's not correct to merge it back.
- monkpit 4y agoWhich is why it would be a branch, no?
- londons_explore 4y agoAnd in this case it seems like mostly an implementation detail - it could just be a flag to enable, or enabled whenever it detects running on colab.
- eoerl 4y agodid you even peek at the link ? There's a PR on diffusers, and it's mentioned on the front page https://github.com/huggingface/diffusers/pull/532#issuecomment-1250134751 https://github.com/huggingface/diffusers/pull/532#issuecomme...