4 ms·
Damn. May as well have used a language that isn’t released yet like Zig. That’s a ton of problems.
by butterisgood 4y ago
Damn. May as well have used a language that isn’t released yet like Zig. That’s a ton of problems.
- TinkersW 4y agoUm no. When I upgraded it was a few hours of work at most, for Google since its code base is extremely large maybe a few days to weeks.
- Matumio 4y agoProbably no big issue for a small to medium codebase. But I doubt the "just a few days" estimate for something as big as a web-browser. If I read correctly they even found use-after-move bugs during the process.
- TinkersW 4y agoThe use after move existed prior, just wasn't moving even though they had written move. It is also written in a way that a linter should be able to detect if you disallow use after move. https://source.chromium.org/chromium/chromium/src/+/main:components/services/storage/indexed_db/locks/disjoint_range_lock_manager.cc;l=136;drc=2705e1173e88110a9778b88a1c3e1be8d103f7e9 https://source.chromium.org/chromium/chromium/src/+/main:com...
- pkasting 4y agoIt's surprisingly hard to detect these sorts of cases reliably; we have a request out to the clang-tidy folks to add some improved detection of use-after-move there.
- pkasting 4y agoTook a couple of months actually, but it's mostly complete now and we're starting to throw the switches.
- ninepoints 4y agoIs this a joke?