3 ms·

Give mysterious things room. In this case the most mysterious is [-3:]. That, together with the split, should have it's own line or maybe even multiple (functio

by im3w1l 4y ago

Give mysterious things room. In this case the most mysterious is [-3:]. That, together with the split, should have it's own line or maybe even multiple (function declaration, comment).

raldi 4y ago
Right?! That should instead be -len("foo") or -NUM_PREFIX_PARAMS
- xigoi 4y ago
  That doesn't improve anything in terms of knowing why the number is there.
  - raldi 4y ago
    len("foo") certainly does, and the global constant is a great place to put a comment, if the name isn't descriptive enough.
ParetoOptimal 4y ago
> [-3:]. That kind of index notation really isn't mysterious if you write a lot of python in my experience.
- im3w1l 4y ago
  The mysterious part isn't what it does. The mysterious part is why. Why are we taking the last three url parameters? What are the meaning of those particular url parameters? Also url parameters are normally used as a unordered key=value dictionary, which makes it strange that we rely on a given order.