4 ms·
Apart from all the childish spaghetti talk, etc. i am wondering if all the removal of code and inlining of functions has some negative side effects (on maintain
by buster 4y ago
Apart from all the childish spaghetti talk, etc. i am wondering
if all the removal of code and inlining of functions has some negative side effects (on maintainability, stability, bugs).
The style of the post makes me think this is some child relentlessly removing structure and security checks...
edit: at least the function was not inlined in code but with some compiler flag.
- daenney 4y ago> The style of the post makes me think this is some child relentlessly removing structure and security checks... Mike is far from a child and his contributions to Mesa speak for themselves. It’s simply his style of writing for these blog posts.
- buster 4y agoI see. Good to know. Still, that's the impression for outsiders.
- lloeki 4y ago200% outsider, and not my impression at all, I largely don't see how "quirky" has to translate to "childish". I could follow the post just well, but maybe my mind was infected by _why's general style. Please, allow me to have one more round of chunky bacon.
- q3k 4y ago> bugs Unsurprisingly it did: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18499?commit_id=fd0d19c50ba3d5eb95b29c84473788a8f0be65fe#note_1551799 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18... But that's what code review and testing is for :).