3 ms·
It's worth pointing out that the commit that did this was made by a Microsoft employee who has been working on the clipboard API, not a Google employee. At a g
by lolinder 4y ago
It's worth pointing out that the commit that did this was made by a Microsoft employee who has been working on the clipboard API, not a Google employee.
At a glance and without very much context, it looks to me like this engineer was working on implementing Web Custom formats for the clipboard API [0], but broke the Google doodle sharing while doing so. It appears they were trying to restore old behavior as a temporary measure, but ended up breaking the checks altogether.
Their commit's comment[1] claims that the added variable should only be true if reading/writing a web custom format, but that obviously isn't the case (anymore?).
EDIT: Here is their original commit, which broke the doodle sharing: [2]. It extends the interaction requirement to custom formats, which wasn't true before. Their followup was meant to just undo that part of this commit, but appears to have done much more.
[0] https://chromestatus.com/feature/5649558757441536 https://chromestatus.com/feature/5649558757441536
[1] https://chromium.googlesource.com/chromium/src/+/4d7b74b051abfe5945f418601fdc2ffc8ce3072c%5E%21/#F0 https://chromium.googlesource.com/chromium/src/+/4d7b74b051a...
[2] https://chromium.googlesource.com/chromium/src/+/a3b96a459cf17ddc683b510718bfcbe40ed08195 https://chromium.googlesource.com/chromium/src/+/a3b96a459cf...
- de6u99er 4y agoThis should be the top comment!
- Jenk 4y agothat feels like a rather fragile process for something that is underpinning the internet to permit such mistakes occur so easily.
- deleted 4y ago[deleted]
- lolinder 4y agoYes. For one thing, it looks like there was an automated test that warned the doodle was broken, but no such test for clipboard security features.
- bdougherty 4y agoAnd underpinning an increasing amount of desktop software now as well.
- ohgodplsno 4y agoCool cool cool, we're breaking browsers because Google has complained that their daily doodle can't be copied. Not worrying at all.
- letssecure 4y agoAll changes are approved by chromium devs.