3 ms·
> then it's the maintainers problem No. Because unlike the one contributing a "not good enough" fix, the maintainer now has to carry the burden of continued ma
by dividuum 4y ago
> then it's the maintainers problem
No. Because unlike the one contributing a "not good enough" fix, the maintainer now has to carry the burden of continued maintenance of that fix. If that fix makes that worse, declining is absolutely reasonable. Of course that's different for fixes with just a typo-level of complexity.
- dschuetz 4y ago> No. Of course it is! It's up to the maintainer to decide! It's their problem, like, literally! Of course, this should not be an invitation to blindly commit and push dumb fixes, even if they solve some problem. But generally: > If that fix makes that worse ... then it's up to the maintainer to politely ask the contributor to make the fix better, or make it better themselves, or bugger off, meaning, then ... > declining is absolutely reasonable. I agree.