5 ms·

No explanation about why. No name for blog post author. No gradual rollout I think? Was this ever a beta feature first like most other things? Compare to Str

by exhaze 4y ago

No explanation about why. No name for blog post author. No gradual rollout I think? Was this ever a beta feature first like most other things? Compare to Stripe product releases where people who built it are instantly on HN, responding to feedback. Is there someone at GH who actually owns the PR experience and sets the long term roadmap for non-enterprise?

exhaze 4y ago
To balance out my parent negative comment, I think the semi recent release of browser VS code on GH web (just press “.”) is awesome. Just wish the PR review experience would get more love.
- codeapprove 4y ago
  Shameless plug but at CodeApprove we’re pretty obsessive about giving the GitHub PR review experience “more love”. Check out https://codeapprove.com https://codeapprove.com if you’re interested
  - turmeric_root 4y ago
    >Shameless you shouldn't be
    - SenHeng 4y ago
      Are you saying they should be ashamed?
      - turmeric_root 4y ago
        yes
- bmitc 4y ago
  Damn. I had no idea about that feature. That is awesome. Although, it doesn't seem to recognize my extensions, even though it automatically logged me into my VS Code account via GitHub's account (which is how I normally do it).
- politelemon 4y ago
  I didn't know about this, that's great. And it's an intuitive URL, github.com gets replaced by github.dev.
brasic 4y ago
Hi, I work on the PRs team. Happy to answer any questions about this change! This was posted in the changelog section of our blog, where posts aren’t attributed. Our roadmap, including PR improvements and features is here: https://github.com/orgs/github/projects/4247/views/1 https://github.com/orgs/github/projects/4247/views/1
shayfrendt 4y ago
Thanks for this feedback! We agree that we could have done a better job providing the motivating background context behind this change. As a result, we went back to the drawing board and rewrote the changelog from scratch to try and increase clarity: https://github.blog/changelog/2022-08-04-commit-comments-no-longer-appear-in-the-pull-request-timeline/ https://github.blog/changelog/2022-08-04-commit-comments-no-... Does this help? We hope you'll accept our pull request. ;-) And yes! We have engineering, product, and design leads supporting the PR experience who are super interested in getting your collective feedback about where we should take the experience next.

by exhaze 4y ago

exhaze 4y ago

To balance out my parent negative comment, I think the semi recent release of browser VS code on GH web (just press “.”) is awesome. Just wish the PR review experience would get more love.

codeapprove 4y ago
Shameless plug but at CodeApprove we’re pretty obsessive about giving the GitHub PR review experience “more love”. Check out https://codeapprove.com https://codeapprove.com if you’re interested
- turmeric_root 4y ago
  >Shameless you shouldn't be
  - SenHeng 4y ago
    Are you saying they should be ashamed?
    - turmeric_root 4y ago
      yes
bmitc 4y ago
Damn. I had no idea about that feature. That is awesome. Although, it doesn't seem to recognize my extensions, even though it automatically logged me into my VS Code account via GitHub's account (which is how I normally do it).
politelemon 4y ago
I didn't know about this, that's great. And it's an intuitive URL, github.com gets replaced by github.dev.

brasic 4y ago

Hi, I work on the PRs team. Happy to answer any questions about this change! This was posted in the changelog section of our blog, where posts aren’t attributed. Our roadmap, including PR improvements and features is here: https://github.com/orgs/github/projects/4247/views/1 https://github.com/orgs/github/projects/4247/views/1

shayfrendt 4y ago

Thanks for this feedback! We agree that we could have done a better job providing the motivating background context behind this change. As a result, we went back to the drawing board and rewrote the changelog from scratch to try and increase clarity: https://github.blog/changelog/2022-08-04-commit-comments-no-longer-appear-in-the-pull-request-timeline/ https://github.blog/changelog/2022-08-04-commit-comments-no-... Does this help? We hope you'll accept our pull request. ;-) And yes! We have engineering, product, and design leads supporting the PR experience who are super interested in getting your collective feedback about where we should take the experience next.