3 ms·
It was very confusing having commit level comments show up in the PR feed along with PR comments. IIRC you couldn't reply to commit comments from a PR (only fro
by corytheboyd 4y ago
It was very confusing having commit level comments show up in the PR feed along with PR comments. IIRC you couldn't reply to commit comments from a PR (only from the commit view) but you could reply to PR comments, which was weird. Seems like a good move to me, but it's unclear what happens when someone replies to an email from GitHub for a commit, does it just go nowhere? Does it go nowhere unless the commit is associated with a PR? What if that PR is closed/merged? Wish this post shared a bit more about what's going on behind the scenes.
- theK 4y agoI don’t get it. From a UX perspective the common expectation would be to be able to see all discussion related to the commits in the PR. If the sources vary give visual clues. It lies close to arrive at “If the user can interact with one comment from a PR view they should be able to interact with all comments, doing otherwise would inhibit discourse”
- corytheboyd 4y agoYeah totally agree, just make it work like every other comment