2 ms·

Then comes the next issue: I really don't like this feature and then direction it will take my project, but this guy has spent hours and there isn't anything t

Then comes the next issue: I really don't like this feature and then direction it will take my project, but this guy has spent hours and there isn't anything technically wrong with the code so I cannot reject it for that reason. Source: been there, done that, someone out there now hates my guts.

kzrdude 4y ago
Right, so it's much better to scope the change first - responding to the feature request with this. Either it's out of scope or one can talk about what part of it would be in scope. Lots of projects have a policy of "talk to the devs before making big changes". I would usually indicate negatively on the feature request if I don't believe it's in scope.