3 ms·
Just reply something like "This feature does not interest me, but patches are welcome!" and leave it at that. This does not mean you actually will merge any PR
by alrlroipsp 4y ago
Just reply something like "This feature does not interest me, but patches are welcome!" and leave it at that.
This does not mean you actually will merge any PR for said future, should they ever materialize.
- neilalexander 4y agoMany people also don’t appear to understand that code comes with an on-going maintenance cost. Even if someone else writes a PR, I may not want to be responsible for that code in future. It’s OK to just say no.
- masklinn 4y ago> This does not mean you actually will merge any PR for said future, should they ever materialize. If you don’t intend to merge the feature, you should not say that patches are welcome, that’s an asshole move. If you’re not sure, say that and that they can open a pr but you can’t make any promise. If you’re not interested in the feature and are not willing to maintain it, say that as well.
- kevincox 4y agoI agree. I think this is what is missing from other responses. What is the problem? 1. This feature is deemed unwelcome and even the most beautiful patch would be rejected. AKA I don't want to maintain it or the feature is actively harmful. 2. Unsure about this feature, but maybe a good patch would be accepted. 3. The feature is fine, but I have no interest in working on this. Patches are welcome. I think valuable information to the other person 1. I guess they should go away or fork. 2. Maybe discuss more, maybe find a way to get a patch written. 3. Wait or find a way to submit a patch.