4 ms·
I love this. One tiny thought - perhaps use a conditional when setting the string percentage/completion value to prepend a 0 of it's < 10? like: completion_str
by ottoflux 4y ago
I love this. One tiny thought - perhaps use a conditional when setting the string percentage/completion value to prepend a 0 of it's < 10?
like:
completion_string: str = '0' + str(self.completion) if self.completion < 10 else str(self.completion)
basically it would keep your bar from shifting when percentage goes from single digit to double digit.
- carrotmoncher 4y agoThis is a pretty good idea, thank you! I will implement this, but instead of a zero ill use a whitespace
- dangrie158 4y agoYou may want to use Format specifiers or fstrings (>py36) for a „more pythonic“ code. Also why do you annotate every variable, even if the type can be deduced automatically? That’s going to be a real PITA if you want to refactor the code e.g to support floats instead of ints any time in the future (in this case it’s probably just a hypothetical problem)
- carrotmoncher 4y agoits mostly for myself, i prefer to annotate variables so i can quickly know what type they should be when writing code (especially for bigger projects). I guess since lowbar is small, its pretty pointless, but its just a habit thats been stuck