4 ms·

> Some angry contributor will disable the CI. I will reject any such contributions and ban anyone who persists with them. I’m not sure what lies below the fold

• wirrbel 4y ago
  Like that is the equivalent to a surgeon not washing their hands..
• UncleMeat 4y ago
  I also do not understand how people end up in this sort of state. To me, absolutely zero new code is going in if builds or tests are failing. Zero. Under any circumstances. I don't care if that failure is a flake. Go demonstrate that it is flakey and disable the test. Don't force a change through red. But... this approach clearly exists. A while ago I was talking with a coworker about some open source upstreaming they wanted to do. They were struggling to get their code out there because they were fighting against all sorts of broken test suites. They were told that this was simply the norm in the community they were contributing to and the test suites are always broken so don't worry about it. Baffled, they made sure that their new tests passed and sent the code off for review and integration. So there is perhaps a need for software engineering principles that apply to this situation. Maybe that's wrong. Maybe the solution is like adopting source control - it is a fool's errand to try to handle the case where it isn't present so just tell everybody to adopt it or they aren't serious. But maybe there is a population that needs tools that help them even in a world of fucked integration tests.