3 ms·

Good catch, that is an issue with the VSCode extension, apparently it’s using the colour for comments (which is purposefully low contrast) for plain text when i

Good catch, that is an issue with the VSCode extension, apparently it’s using the colour for comments (which is purposefully low contrast) for plain text when it should be using the main foreground colour. I’ll try to look into that! Also, the light theme only has a “barely enough contrast” version due to constraints described in the README, the dark theme has options with much more. (compare it to the greys used in the samples and you’ll see what I mean)

powersnail 4y ago
That makes sense; I thought it kinda looks like comment. Pretty pleasant colors, otherwise. Good work!
- solasluaith 4y ago
  Thank you, I’m glad you enjoy them!
edwintorok 4y ago
FWIW comments are quite an important part of reading code, it should not be hidden, at least when comments are used for documentation purposes. It shouldn't be as prominent as the main code, but should be pretty close to it. Very few color themes get this right.
- solasluaith 4y ago
  I’m not sure if I’m already using the closest colour in terms of luminance or not, I’d have to check. If not, I’m very open to pull requests on the theme, including fundamental reworks. Otherwise there might be an argument whether one would want to make the closest de-emphasised colour less so, but that would require more fundamental changes to the palette (which I’m also open to for the background colours!). I think for this part I looked at what others were doing so I might have gotten it wrong from them.
steve_gh 4y ago
Just tried it on VSCode. The Penumbra light doesn't map very well in a few places. If you open the "Editor Playground" page, some of the code samples have some pretty unreadable sections, because the background grey is too close to the foreground colours. Nice idea, but I'm afraid that for coding I'm going to be sticking with Solarized light for the moment.
- solasluaith 4y ago
  Feel free to make either an issue or even a pull request, I’m very much looking for feedback on the implementation! Do you have the same issues with the Dark Contrast++ version?

powersnail 4y ago

That makes sense; I thought it kinda looks like comment. Pretty pleasant colors, otherwise. Good work!

solasluaith 4y ago
Thank you, I’m glad you enjoy them!

edwintorok 4y ago

FWIW comments are quite an important part of reading code, it should not be hidden, at least when comments are used for documentation purposes. It shouldn't be as prominent as the main code, but should be pretty close to it. Very few color themes get this right.

solasluaith 4y ago
I’m not sure if I’m already using the closest colour in terms of luminance or not, I’d have to check. If not, I’m very open to pull requests on the theme, including fundamental reworks. Otherwise there might be an argument whether one would want to make the closest de-emphasised colour less so, but that would require more fundamental changes to the palette (which I’m also open to for the background colours!). I think for this part I looked at what others were doing so I might have gotten it wrong from them.

steve_gh 4y ago

Just tried it on VSCode. The Penumbra light doesn't map very well in a few places. If you open the "Editor Playground" page, some of the code samples have some pretty unreadable sections, because the background grey is too close to the foreground colours. Nice idea, but I'm afraid that for coding I'm going to be sticking with Solarized light for the moment.

solasluaith 4y ago
Feel free to make either an issue or even a pull request, I’m very much looking for feedback on the implementation! Do you have the same issues with the Dark Contrast++ version?