4 ms·
For a long time, it was worse than that - once a change was "accepted", you could amend the commit with changes to literally any other file in the entire monore
by avalys 4y ago
For a long time, it was worse than that - once a change was "accepted", you could amend the commit with changes to literally any other file in the entire monorepo, and land it without any further review.
They finally added a "final review" step to ensure that someone eventually takes a look at these changes after the initial accept, but that still occurs several days after the commit.
- toast0 4y agoCan you still add Reviewed-by: yourself in the commit message to skip review? That was my favorite one.