5 ms·
8 commits to disable console logging in production? How many hours did they charge for that? I would imagine that it would take more time to commit 8 times tha
by d1sxeyes 4y ago
8 commits to disable console logging in production?
How many hours did they charge for that? I would imagine that it would take more time to commit 8 times than to actually change this…
- mtlynch 4y agoI don't think number of commits is a meaningful metric. They billed two hours. It sounds like it's a one-line change, but getting it to play nice with CI is a little more complicated. It was very similar to this change, so two hours felt reasonable: https://github.com/mtlynch/whatgotdone/pull/745 https://github.com/mtlynch/whatgotdone/pull/745
- d1sxeyes 4y agoAlthough I agree number of commits is not a meaningful metric, it seems a bit... wrong. I think if you're happy with this, then OK. For me, 2 hours is an awful lot of work for this.