3 ms·
This is exactly the kind of projects I like. The stuff where people make something to solve a personal problem. There's a few things that can be tidied up thou
by hnlmorg 4y ago
This is exactly the kind of projects I like. The stuff where people make something to solve a personal problem.
There's a few things that can be tidied up though:
1. Your README instructions references `bin/import_csv` but the file name in the repo is `import_bank_csv`
2. You have a bunch of `use` statements in your `import_bank_csv` file which are not being used. Weirdly including `switch` yet you have a `elsif` block.
3. `import_bank_csv` also has a stray `1;` at the end of it. This is only really needed for Perl modules.
4. In addition to 3, some of your Perl modules do have `1;` and some don't. There isn't any consistency there.
I do share your love for Perl even though it definitely has a lot of hidden traps (I'd even go as far as to say it's not a well designed language by modern standards). But the fact I still hear about Perl scripts I'd written for jobs 10+ years previously, and running on production systems without any additional maintenance, says a lot about the stability of the Perl ecosystem.
- hestefisk 4y agoThank you for the feedback! 1. Spot on, I have fixed the README instructions :) It was written in a rush. Apologies. 2. You are right. I have removed the unused use statements. I had the switch statement imported as I wanted to try out the 'given ...' construct but it was easier just to use if-elsif. 3. Good point, removed. 4. Yes, absolutely. Thank you! Having spent almost 15 years away from Perl in various other languages, I actually tthink Perl is quite elegant. You can do some pretty neat code in a very succinct way, as long as you keep your code structured and avoid too many clever things. The Perl stack definitely allows you to hammer a nail into your own foot, but it doesn't mean you have to. :)
- hestefisk 4y agoBTW, I have now significantly improved the documentation and also added installation instructions. :)